JSAMP update

[Mark Taylor]

Hi Tom,

here is how you can test it.

Note it's the astropy hub that is under test here, so the sending 
web application and the receiving SAMP client don't make a difference.

So to test it with and without the change you want to do something like:

  1. start the hub under test: e.g. run the astropy standalone program
     samp_hub

  2. start a suitable desktop client (e.g. topcat or aladin) - note you
     should do this after starting the hub, otherwise certain clients
     will start their own hub instead

  3. send a message from a web application to the desktop client.
     Any old web-samp client will do, e.g. you can send the result of
     a Vizier query with the "Send to VO tools" button on the top right
     of the results page, or use the minimal samp web app at
     https://astrojs.github.io/sampjs/examples/send.html

Note when you do the send, the python hub will ask you for consent
on the console, so make sure that you're watching that.

Figuring out the difference between the behaviour before and after
the fix is also a bit subtle.  As far as I know the send will complete
successfully in both cases using all known browsers.
However, if you carry out step 3 using recent versions of google chrome
(e.g. v122), then with the unfixed version, the chrome developer console
(ctrl-shift-I) will report warnings (orange flags) labelled 
"Ensure private network requests are only made to resources that allow 
them".  In the version corresponding to Astropy PR #16193, no warnings.

Mark

On Thu, 14 Mar 2024, Tom Donaldson wrote:

> Thanks Mark and Pierre,
> 
> I’m going to approve the Astropy PR, but I was curious to try it out myself as well.  Can either of you recommend a suitable web app (maybe with and without the new JSAMP) to use for testing?
> 
> Thanks,
> Tom
> 
> 
> From: apps <apps-bounces at ivoa.net> on behalf of Applications WG <apps at ivoa.net>
> Reply-To: Mark Taylor <m.b.taylor at bristol.ac.uk>
> Date: Thursday, March 14, 2024 at 7:08 AM
> To: Pierre Fernique <Pierre.Fernique at astro.unistra.fr>
> Cc: Applications WG <apps at ivoa.net>
> Subject: Re: JSAMP update
> 
> External Email - Use Caution
> 
> Good!  thanks for the test.
> 
> I have also made an Astropy Pull Request implementing a corresponding
> change to the Astropy hub Web Profile implementation:
> 
>    https://urldefense.com/v3/__https://github.com/astropy/astropy/pull/16193__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!xGJ3X7vGDlGCb8mZS1WQMu5hkDC1D1osc1MqogivKFZxXtGxImu5EbqVz4MEFDOmUTAQf5T6IyLUbw$<https://urldefense.com/v3/__https:/github.com/astropy/astropy/pull/16193__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!xGJ3X7vGDlGCb8mZS1WQMu5hkDC1D1osc1MqogivKFZxXtGxImu5EbqVz4MEFDOmUTAQf5T6IyLUbw$>
> 
> Mark
> 
> On Thu, 14 Mar 2024, Pierre Fernique via apps wrote:
> 
> Bonjour,
> 
> Implemented and tested in Aladin Desktop (v12.125). Works like a charm, even
> with latest Chrome version (122.0.6261.129 (Build officiel) (64 bits))
> Thanks for this update
> Pierre
> 
> Le 13/03/2024 à 14:45, Mark Taylor via apps a écrit :
> > Hi apps,
> >
> > as promised in my email of a couple of days ago I have made an
> > update JSAMP release, v1.3.8, with modifications that enable
> > the Hub Web Profile implementation to cope with Private Network
> > Access-related restrictions in (at least) recent versions of
> > Google Chrome.
> >
> > If you are bundling a JSAMP hub with your application, you are
> > advised to upgrade to this newer version.
> >
> > You can find jsamp-1.3.8.jar athttps://www.star.bristol.ac.uk/mbt/jsamp/
> > or on the Maven central repository under groupId uk.ac.starlink
> > (https://urldefense.com/v3/__https://central.sonatype.com/artifact/uk.ac.starlink/jsamp__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!xGJ3X7vGDlGCb8mZS1WQMu5hkDC1D1osc1MqogivKFZxXtGxImu5EbqVz4MEFDOmUTAQf5SFE_WcQw$<https://urldefense.com/v3/__https:/central.sonatype.com/artifact/uk.ac.starlink/jsamp__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!xGJ3X7vGDlGCb8mZS1WQMu5hkDC1D1osc1MqogivKFZxXtGxImu5EbqVz4MEFDOmUTAQf5SFE_WcQw$> ).
> > This release does not include a signed jar file; I'm not sure I can
> > do much about that, but if that fact inconveniences anybody I'd
> > at least be interested to know.
> >
> > This is the first JSAMP release since 2019 and although it still
> > works it's looking a bit old and creaky - no generics and the
> > build is currently done using javac 1.4 source and target flags,
> > which are unsupported in recent JDK versions.
> > I *may* make a new release with the API updated to use generics
> > in the forseeable future (if you're keen to see that, feel free
> > to lobby me).
> >
> > Mark
> >
> >
> >
> > --
> > Mark Taylor  Astronomical Programmer  Physics, Bristol University, UK
> > m.b.taylor at bristol.ac.uk<mailto:m.b.taylor at bristol.ac.uk>           https://urldefense.com/v3/__https://www.star.bristol.ac.uk/mbt/__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!xGJ3X7vGDlGCb8mZS1WQMu5hkDC1D1osc1MqogivKFZxXtGxImu5EbqVz4MEFDOmUTAQf5Q_KU-gAg$<https://urldefense.com/v3/__https:/www.star.bristol.ac.uk/mbt/__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!xGJ3X7vGDlGCb8mZS1WQMu5hkDC1D1osc1MqogivKFZxXtGxImu5EbqVz4MEFDOmUTAQf5Q_KU-gAg$>
> 
> 
> --
> Mark Taylor  Astronomical Programmer  Physics, Bristol University, UK
> m.b.taylor at bristol.ac.uk<mailto:m.b.taylor at bristol.ac.uk>          https://urldefense.com/v3/__https://www.star.bristol.ac.uk/mbt/__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!xGJ3X7vGDlGCb8mZS1WQMu5hkDC1D1osc1MqogivKFZxXtGxImu5EbqVz4MEFDOmUTAQf5Q_KU-gAg$<https://urldefense.com/v3/__https:/www.star.bristol.ac.uk/mbt/__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!xGJ3X7vGDlGCb8mZS1WQMu5hkDC1D1osc1MqogivKFZxXtGxImu5EbqVz4MEFDOmUTAQf5Q_KU-gAg$>
> 
> 

--
Mark Taylor  Astronomical Programmer  Physics, Bristol University, UK
m.b.taylor at bristol.ac.uk          https://www.star.bristol.ac.uk/mbt/