<div dir="ltr"><div>Hi Mark,</div><div><br></div><div>Thanks for your comments. They are all good and I will make the necessary edits. Regarding the group identifiers, <span style="font-size:small;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">I will respond to that in a second email that has Markus' comments on the same topic.</span></div><div><span style="font-size:small;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div><div><span style="font-size:small;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Brian</span></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 3, 2019 at 3:34 PM Mark Taylor <<a href="mailto:M.B.Taylor@bristol.ac.uk">M.B.Taylor@bristol.ac.uk</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Brian,<br>
<br>
a few comments on WD-GMS-1.0-20190329 as requested:<br>
<br>
On changing the IVOID scheme from ivo to gms:<br>
As I understand it, it's not an IVOID if it doesn't use the "ivo" scheme.<br>
IVOID 2.0 section 2.3.1 says: "The <scheme> part of IVOIDs is ivo.".<br>
<br>
I think(?) that you should abandon the idea of syntactically signalling<br>
that an IVOID is a Group Identifier. It's not necessary to do that<br>
anyway, that's properly signalled by context: an IVOID can be<br>
treated as a Group Identifier if a capability of its resource has<br>
standard_id="ivo://<a href="http://ivoa.net/std/gms#search-1.0" rel="noreferrer" target="_blank">ivoa.net/std/gms#search-1.0</a>" (er, or something<br>
like that).<br>
<br>
Note that the examples in section 4.2 still use the ivo scheme<br>
in any case - at least usage has to be consistent.<br>
<br>
Section 3.2 item 3:<br>
The IVOID standard seems to use the term "resource key" rather <br>
than "path" for this part of the identifier (IVOID 2.0 section 2.3.3).<br>
I can't remember if there's an important reason for that, but it<br>
might be a good idea to follow the IVOID rather than URI terminology.<br>
<br>
Section 4.1: "(ending with a newline character)": <br>
I suggest (being mindful of Goldfarb's First Law of Text Processing) <br>
to be explicit here about what's meant by "a newline character".<br>
I seem to remember that text/plain is supposed always to use CRLF; <br>
I can't now find a reference for that, but CRLF is the line end <br>
sequence used by RFC822 and HTTP, so it would probably make a <br>
good choice.<br>
<br>
Section 4.1: <br>
The terms "user" and "principal" are still used in several places, <br>
I think the intention was to change these to "identity" and <br>
"identityType" passim.<br>
<br>
Section 4.2:<br>
"This resolves ... to host <a href="http://server.example.com/groupService/search" rel="noreferrer" target="_blank">http://server.example.com/groupService/search</a>"<br>
- should probably say "to URL" not "to host".<br>
<br>
Examples (sections 3.2, 4.2):<br>
In the examples it might be a good idea to resolve to (e.g.)<br>
<a href="https://example.com/." rel="noreferrer" target="_blank">https://example.com/.</a>.. rather than <a href="http://example.com/.." rel="noreferrer" target="_blank">http://example.com/..</a>.,<br>
given that real-life use of this protocol will presumably be<br>
taking security issues seriously.<br>
<br>
References:<br>
A few of the references in the bibliography point at out of date<br>
document versions; unless there's some reason the older versions<br>
are preferred, you could update Datalink (to REC), DALI (to v1.1)<br>
and SSO (to v2.0).<br>
<br>
Apart from these, I think it looks basically comprehensible and<br>
well designed.<br>
<br>
Mark<br>
<br>
On Mon, 1 Apr 2019, Brian Major wrote:<br>
<br>
> Hi Grid,<br>
> <br>
> A second Group Membership Service (GMS) working draft is available:<br>
> <a href="http://www.ivoa.net/documents/GMS/20190329/WD-GMS-1.0-20190329.pdf" rel="noreferrer" target="_blank">http://www.ivoa.net/documents/GMS/20190329/WD-GMS-1.0-20190329.pdf</a><br>
> <br>
> Please have a look and provide your feedback through email or on this page:<br>
> <a href="https://wiki.ivoa.net/twiki/bin/view/IVOA/GroupMembershipService" rel="noreferrer" target="_blank">https://wiki.ivoa.net/twiki/bin/view/IVOA/GroupMembershipService</a><br>
> <br>
> From the 'what has changed' section in the document:<br>
> - Changed GMS IVOID to be in the format gms://authority/path?group<br>
> - Changed names of params user and principal to identity and<br>
> identityType<br>
> - Corrected API definition to always return 200 on success<br>
> - REST API now described in a table<br>
> <br>
> We'll review and discuss the draft in Paris but it would be good if<br>
> feedback could be received ahead of that meeting.<br>
> <br>
> Cheers,<br>
> Brian<br>
> <br>
<br>
--<br>
Mark Taylor Astronomical Programmer Physics, Bristol University, UK<br>
<a href="mailto:m.b.taylor@bris.ac.uk" target="_blank">m.b.taylor@bris.ac.uk</a> +44-117-9288776 <a href="http://www.star.bris.ac.uk/~mbt/" rel="noreferrer" target="_blank">http://www.star.bris.ac.uk/~mbt/</a><br>
</blockquote></div></div>