<div dir="ltr">Not sure I follow. Wouldn't a Matrix2D be a Matrix with M=2, N=2?<div>We could discuss the names, but these seemed pretty standard and are described as M rows, N columns. I know I always have to go back and review which way is rows and which is columns, but I don't deal with matrices very often.</div><div><br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 2, 2020 at 8:50 AM Laurent MICHEL <<a href="mailto:laurent.michel@astro.unistra.fr">laurent.michel@astro.unistra.fr</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Dear,<br>
<br>
Comment #3:<br>
<br>
- The matrix operation class (Matrix) seems to refer to a 2D matrix. The <br>
class could be renamed Matrix2D to keep room for future high <br>
dimensionality classes<br>
<br>
- The matrix dimensions are named N and M. Personally, I'm pretty sure <br>
to always confuse N.M and M.N. It could be safer to renamed these <br>
attributes with something more expressive like (row, columns)<br>
<br>
LM<br>
-- <br>
-- <br>
---- Laurent MICHEL Tel (33 0) 3 68 85 24 37<br>
Observatoire de Strasbourg Fax (33 0) 3 68 85 24 32<br>
11 Rue de l'Universite Mail <a href="mailto:laurent.michel@astro.unistra.fr" target="_blank">laurent.michel@astro.unistra.fr</a><br>
67000 Strasbourg (France) Web <a href="http://astro.u-strasbg.fr/~michel" rel="noreferrer" target="_blank">http://astro.u-strasbg.fr/~michel</a><br>
---<br>
</blockquote></div>