<div dir="ltr">Hi Kristin<br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 23, 2017 at 5:21 AM, Kristin Riebe <span dir="ltr"><<a href="mailto:kriebe@aip.de" target="_blank">kriebe@aip.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all,<br>
<br>
when looking at SimDM at implementing it (well, parts of it) for our<br>
simulations, I realized that one of the multiplicities in the UML<br>
diagram (and its description) at<br>
<a href="http://www.ivoa.net/documents/SimDM/20120503/html/SimDM.html" rel="noreferrer" target="_blank">http://www.ivoa.net/documents/<wbr>SimDM/20120503/html/SimDM.html</a><br>
is not correct.<br>
<br>
The multiplicity for the composition relation from InputDataset to<br>
InputDataObject is given as 0..1 (at the end), but it should be 0..*. 1<br>
<br>
Each InputDataset can consist of 0 to many InputDataObjects (and each of<br>
them has a reference to 1 DataObject).<br>
That's also what the annotation to InputDataset.object says:<br>
"Collection of object associations that identify explicitly which<br>
objects from a collection of objects are used as input data in an<br>
experiment."<br>
I had discussed this already with Gerard, and he agrees that this is a typo.<br></blockquote><div>I still do. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Since these classes and their multiplicities are not explicitly<br>
mentioned in the standard document, could someone please just correct<br>
the vodml-version and re-generate the html-description and diagram? Or<br>
is a minor version update/erratum needed for this?<br>
<br></blockquote><div><br></div><div>My proposal would be to actually create a proper VO-DML version of SimDM and do the fixes there.</div><div>The existing representations of SimDM are MagicDraw and an "intermediate" XML representation. The latter was produced by and used in VO-URP, which was also used to generate HTML and XSD representations of the model.</div><div>As VO-DML is VERY close to the VO-URP representation, a port will be straightforward (i have one already, though need updating to latest VO-DML). This update will contain:</div><div>- (VO-)UML diagram in magicdraw, conforming to the VO-DML profile. This will replace the UML conforming to the VO-URP propfile in the </div><div>- VO-DML/XML representaiton generated form the UML.</div><div>- HTML documentaiton generated from the VO-DML/XML.</div><div>At the moment we do not have an automated mapping from UML to XML schema (XSD), but that is not a requirement.</div><div><br></div><div>What do theory and dm chairs think about this proposal? An extra benefit of a Vo-DML representation could be its usage in SimDAL or so, if that wants annotated VOTables. With the mapping spec in progress that would be a nice use case.</div><div><br></div><div>I can update the vo-dml/models/simdm/ folder on volute with these artifacts.</div><div> </div><div>Cheers</div><div>Gerard</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Cheers,<br>
Kristin<br>
<br>
<br>
P.S.:<br>
In the diagram at<br>
<a href="http://www.ivoa.net/documents/SimDM/20120503/uml/SimDM_DM.png" rel="noreferrer" target="_blank">http://www.ivoa.net/documents/<wbr>SimDM/20120503/uml/SimDM_DM.<wbr>png</a> (I guess<br>
this is a direct export from MagicDraw?), there is no multiplicity given<br>
and thus it probably defaults to 0..1 and thus the auto-generated<br>
diagram and description at<br>
<a href="http://www.ivoa.net/documents/SimDM/20120503/html/SimDM.html" rel="noreferrer" target="_blank">http://www.ivoa.net/documents/<wbr>SimDM/20120503/html/SimDM.html</a> contain the<br>
0..1.<br>
<br></blockquote><div>indeed that is the case. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
P.P.S: There are also still some "TODO" flags in annotations to some<br>
classes, maybe these could be filled with some meaningful text as well.<br>
(e.g. ObjectCollection, OutputDataset, all attributes of DataObject)<br>
<br>
<br>
--<br>
------------------------------<wbr>-------------------------<br>
Dr. Kristin Riebe<br>
E-Science & GAVO<br>
<br>
Email: <a href="mailto:kriebe@aip.de">kriebe@aip.de</a><br>
Phone: <a href="tel:%2B49%20331%207499-377" value="+493317499377">+49 331 7499-377</a><br>
Room: B6/25<br>
------------------------------<wbr>-------------------------<br>
Leibniz-Institut für Astrophysik Potsdam (AIP)<br>
An der Sternwarte 16, D-14482 Potsdam<br>
Vorstand: Prof. Dr. Matthias Steinmetz, Matthias Winker<br>
Stiftung bürgerlichen Rechts<br>
Stiftungsverzeichnis Brandenburg: 26 742-00/7026<br>
------------------------------<wbr>-------------------------<br>
</blockquote></div><br></div></div>