<div dir="ltr"><div><div><div><div><div><div><div><div><div><div><div><div><div><div><div><div><div><div><div><div><div><div><div><div><div>Gerard/DMers,<br><br></div>With the couple element pattern restriction items which have come up recently and my experience working with the xslt script for Modelio, I decided to give the doc another full read/review. Below are some comments.. many I believe have been mentioned before on an earlier draft. Most are typographical or consistency items between text and figures.<br><br></div>VO-DML document: V1.0-20151007<br></div><div><br>pg 15:Figure 1<br></div> + Contraint is not an extension of ReferableElement<br></div> + missing SubsettedRole<br><br></div>pg 18:Section 4.1.1<br></div> + pattern shown here (and reported by validator), does not match that <br></div>    shown in the VO-DML/Schema snippet for "ElementID" on pg 19<br></div>     "[\w\._-]+" vs "[\w\./_*]+"<br><br></div>pg 18:Section 4.1.2<br></div> + already reported separately, the pattern enforced by the validator <br></div>     does not match the definition of xsd:NCName, namely by the omission<br></div>     of '.' and '-' characters... possibly others<br><br></div>     It would be helpful to have a pattern or short description here.<br><br></div>pg 18:Figure 4<br></div> + description ends mid-sentence.<br><br></div>pg 18: footnote.. 'will be left out in from now on' => 'will be left out from now on'<br><br></div>pg 20: VO-UML<br></div> + 'This type has not explicit counterpart in VO-UML,' s/b<br></div><div>    ' This type has no explicit counterpart in UML,'<br><br></div><div>pg 20: VO-DML/Schema<br></div><div> + pattern shown here '[\w_-]+:[\w\./_*]+'<br></div><div>    a) indicates a pattern for the 'prefix', which is not stated in the Model.name description<br></div><div>        I'm not sure what the validator enforces on this one.<br></div><div>    b) the ID pattern matche the previous schema snippet, not Section 4.1.1/validator pattern.<br><br><br></div><div>pg 22: VO-DML/XML<br></div><div> + I'll mention it once here, but several of the XML examples don't include the closing tag, which they probably should, for completeness.. makes it clear that there is nothing missing.<br><br></div>pg 22: Section 4.4.1<br></div> + does not mention the pattern restriction shown above in the Schema snippet<br></div> + also, subsequent Schema snippet on pg 25 shows Model.name has type "ModelPrefix"<br></div>    which does not exist in the document.<br><br></div>pg 24: Figure 7<br></div> + profile tags for model stereotype do not match text and what is being used in the IVOA_UML_Profile ('title', 'version', 'authors', previousVersion' )<br><br></div><div>pg 25: VO-DML/Schema<br></div><div> + above mentioned.. Model element 'name' has type 'ModelPrefix' which is not in the document.<br><br></div><div>pg 26: Section 4.5.3<br></div><div> + url type 'anyURL' is 'anyURI' in schema snippet of page 27<br><br></div><div>pg 27: Figure 8<br></div><div> + modelimport stereotype tags do not match text and IVOA_UML_Profile.<br></div><div>    (version, url, documentationURL)<br></div><div> + description states 'possible tags'.. isn't this defining the tags?<br><br></div><div>pg 32: Section 4.9.1<br></div><div>pg 33: Section 4.10<br></div><div> + could use some clarification of the pattern restriction in light of the list discussion.<br><br></div><div>pg 35: Figure 12<br></div><div> + object has stereotype <<dataType>>, while description shows <<datatype>><br><br></div><div>pg 39: VO-DML/Schema<br></div><div> + '... and multiplicity that defines whether.'  ends mid-sentence.<br><br></div><div>pg 39: Section 4.14.1<br></div><div> + element name == 'semanticconcept', but text references 'topconcept'.<br></div><div>    If I'm reading this right, the word "topconcept" is referring to this element name "semanticconcept", and not the 'topConcept' attribute on the SemanticConcept type.<br></div><div><br></div><div>pg 40: VO-DML/Schema<br></div><div> + related to above, the element name should be 'semanticconcept'<br><br></div><div>pg 42: top of page<br></div><div> + large space in final sentence.<br><br></div><div>pg 61: Appendix C<br></div><div> + 'for generating such unique [word missing], and the following grammar is built starting from [such s/b 'this'?] previous attemp'<br><br><br></div></div>